Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breast Cancer Prediction #129

Open
wants to merge 24 commits into
base: master
Choose a base branch
from
Open

Breast Cancer Prediction #129

wants to merge 24 commits into from

Conversation

murtaza-sadri-19
Copy link

#33

Checklist

  • My code follows the current project structure
  • I have thoroughly reviewed and updated the requirements.txt file to include any new packages
  • The predict.py file includes a properly implemented model_details() function, or the notebook contains this function to print a detailed model report. The model will not be accepted without this function, as it is essential for generating the necessary model details.
  • I have added relevant tests (if necessary).
  • I have added comments in the code where needed.
  • This PR is submitted under Hacktoberfest.
  • This PR is submitted under GirlScript Summer of Code (GSSoC-Extd).

@murtaza-sadri-19 murtaza-sadri-19 mentioned this pull request Oct 12, 2024
Closed
@murtaza-sadri-19 murtaza-sadri-19 mentioned this pull request Oct 13, 2024
Closed
@murtaza-sadri-19
Copy link
Author

@yashasvini121 Please review this

yashasvini121
yashasvini121 requested changes Oct 15, 2024
View reviewed changes
Copy link
Owner

@yashasvini121 yashasvini121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have not made any changes to your code since the last review. Let me know if you face any errors

@murtaza-sadri-19
Copy link
Author

murtaza-sadri-19 commented Oct 16, 2024 •
edited
Loading

You have not made any changes to your code since the last review. Let me know if you face any errors
I have updated the model path and details in pages.json and removed model_details.

Hi @yashasvini121,
I have updated model path and model details in pages.json
I have removed model_details function

Please check commit 5b9abae for the changes. Let me know if you encounter any errors!

@murtaza-sadri-19
Copy link
Author

You have not made any changes to your code since the last review. Let me know if you face any errors

I not getting how to add model details into notebook as you said to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yashasvini121 yashasvini121 yashasvini121 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@murtaza-sadri-19 murtaza-sadri-19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@murtaza-sadri-19 @yashasvini121